Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the project's dependency management and testing infrastructure by migrating from pip/requirements.txt to uv, updating Python version support, and removing outdated PyOpenSSL workarounds. The changes consolidate dependency specifications into pyproject.toml, update CI workflows, and simplify the codebase.
Key changes:
- Migrates from pip to uv for dependency management
- Drops support for Python 3.5-3.9, adds support for Python 3.13-3.14
- Removes PyOpenSSL-specific workarounds that are no longer needed
- Consolidates dependencies into pyproject.toml optional-dependencies
Reviewed Changes
Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | New lockfile generated by uv containing all project dependencies |
| tox.ini | Updated to use tox-uv, removed old Python versions, added typecheck environment |
| test-requirements.txt | Removed (migrated to pyproject.toml) |
| requirements.txt | Removed (migrated to pyproject.toml) |
| MANIFEST.in | Removed (no longer needed with modern packaging) |
| pyproject.toml | Added test optional-dependencies group and updated dev/docs groups |
| tdclient/api.py | Removed PyOpenSSL workarounds for bytearray/array handling |
| tdclient/test/api_test.py | Removed conditional assertions for PyOpenSSL behavior |
| tdclient/import_api.py | Renamed parameters to avoid shadowing built-ins |
| tdclient/bulk_import_api.py | Renamed parameters to avoid shadowing built-ins |
| README.rst | Updated documentation to reflect uv usage |
| .python-version | Updated to Python 3.10-3.14 |
| .github/workflows/pythontest.yml | Updated CI to use uv instead of pip |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, dropping pyopenssl test in tox because it was resolved 6 years ago.